Escape \u2028 and \u2029 in JSON output.

[tomchristie]

Closes #2169.

[jpadilla]

LGTM but I'm thinking we should just fix this under the JSONPRenderer instead.

[tomchristie]

Perhaps. I'm expecting we'll also have folks using JSONRenderer and putting the results into a template as a javascript variable.

[jpadilla]

Makes sense. Having it under the JSONRenderer covers both cases so that's good.

[tomchristie]

Don't feel like there's any great solutions here - not wild about potential for it to be an unneeded minor performance hit for the folks who don't need it, but there's no real way round it, so. (And presumably not actually an issue, but still meh)

[jpadilla]

I still haven't seen any further reports about it though, so I think its totally valid we consider actually adding this vs perhaps leaving as is for now. Also, now that I think of it, might be interesting to allow users to swap json.dumps on the renderer for something like simplejson.dumps instead.

[tomchristie]

I think its totally valid we consider actually adding this vs perhaps leaving as is for now.

Sorry, wasn't clear what you synopsis was on this?

[jpadilla]

@tomchristie sorry for not being more clear. What I mean was that if we weren't happy with adding this and hasn't been a recurring brought-up issue we could just leave it out for now specially if you're worried about any potential hits for the 99.99% who haven't had this problem.

[tomchristie]

Just fixing the damn thing.

JSON spec authors oughta get their shit together and put a single para ammendment in recommending that those 2 chars be escaped and.
Python team oughta get their shit together and fix it in the json pacakge directly.

:-|