Added support for the to_field on ForeignKey fields #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # see also ForeignKey and ForeignObject in | ||
| # https://docs.djangoproject.com/en/1.7/_modules/django/db/models/fields/related/ | ||
|
|
||
| if django.VERSION >= (1, 6): |
There was a problem hiding this comment.
This is the minimum supported version in master, so oughta be able to drop the compat bit.
|
@jpadilla Done |
|
@tomchristie if you have no further feedback, I think this is good to go. |
|
Great work, yup! |
tomchristie
added a commit
that referenced
this pull request
Oct 21, 2015
Added support for the to_field on ForeignKey fields
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2426.
Rebased copy of PR #2435 which is abandoned by the author