Min/MaxValueValidator is no longer transferred from a model's DecimalField #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for a regression where the `min_value` and `max_value` arguments are not being set for a DRF `DecimalField` even though the corresponding `MinValueValidator` and `MaxValueValidator` is being set on the model fields. Note that this only appears to be a regression for Django < 1.9, as these regression tests pass on newer versions of Django.
kevin-brown
force-pushed
the
decimalfield_validators
branch
from
c9d29f1 to
9bab640
Compare
Previously, all validators set on a DecimalField in Django would be stripped when converted to a Django REST framework field. This was because any validator that was an instance of `DecimalValidator` would be removed, and when `DecimalValidator` wasn't supported (so it was `None`), all validators would be removed. This fixes the issue by only removing the `DecimalValidator` instances if the `DecimalValidator` is supported.
This test was incorrectly checking that there were no validators set in older versions of Django, even though it should have been checking for the two validators that were set up on the model field level. The originally regression test that this fixes was added in 7d79cf3 when fixing an issue with the `DecimalValidator`.
|
@kevin-brown yep def reasonable, good work hunting this down. |
kevin-brown
force-pushed
the
decimalfield_validators
branch
from
1c9c2e5 to
294a183
Compare
|
Nice work 👍 |
| @@ -130,7 +130,7 @@ def get_field_kwargs(field_name, model_field): | |||
|
|
|||
| # Our decimal validation is handled in the field code, not validator code. | |||
| # (In Django 1.9+ this differs from previous style) | |||
| if isinstance(model_field, models.DecimalField): | |||
| if isinstance(model_field, models.DecimalField) and DecimalValidator: | |||
| validator_kwarg = [ | |||
| validator for validator in validator_kwarg | |||
| if DecimalValidator and not isinstance(validator, DecimalValidator) | |||
There was a problem hiding this comment.
We could probably remove the check against DecimalValidator at line 136 since it's redondant with the one line 133.
Edit: "the check against DecimalValidator" meaning "if DecimalValidator and not isinstance(validator, DecimalValidator)" -> if not isinstance(validator, DecimalValidator)
These two tests were previously added in 7d79cf3 but we have now discovered that there are not actually two separate cases, there was just a bug in the code that made it look that way. This also removes a redundant check to see if `DecimalValidator` was defined.
kevin-brown
force-pushed
the
decimalfield_validators
branch
from
294a183 to
a772326
Compare
xordoquy
added a commit
that referenced
this pull request
Jan 4, 2016
Min/MaxValueValidator is no longer transferred from a model's DecimalField
|
@kevin-brown \o/ thanks a lot ! |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from DRF 3.2.5 to 3.3.2, a bunch of our tests started failing because the
min_valueandmax_valueare no longer being transferred over to the automatically generated fields. This is a regression that does not appear to be documented anywhere, and there is still code that is supposed to be setting these arguments.