Fixed admin pagination when limit is 0 #3990
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix #3444.
It is a simpler fix because it simply forces limit to never be 0. By default, if limit is given as 0, then
max_limit
is used as limit. But this can be changed in a subclass if somebody prefers to usedefault_limit
in such case as well.This allows one to request a default limit (by not providing
limit
query parameter) or request a max limit (by providing it withlimit=0
as a query parameter).