Fields. Fix None values representation in childs of ListField, DictField. #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.40%@@ master #4118 diff @@
==========================================
Files 51 51
Lines 5476 5476
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 5005 5005
Misses 471 471
Partials 0 0
|
|
Good stuff, thanks! 😄 👍 |
|
@tomchristie Thanks. Sorry, I don't know, that first need to do issue and make pull request without issue. Should I do it now? |
|
Nope not to worry, thought there was an existing issue, but not a problem if there isn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None values in childs of DictField, ListField not check in representation.