Django 1.10 support.

[tomchristie]

Working towards Django 1.10 support.

[xordoquy]

Is this needed by Django 1.10 ?

[tomchristie]

For one reason or another, yes.

I've not dug into why yet, but presumably we were previously having it automatically included by the RequestContext. I assume that we could also change our settings in order to resolve this (eg perhaps context processor configuration has moved to being part of the TEMPLATES dictionary?)

In any case it's probably best that we pass it explicitly, rather than relying on the correct context processors being set.

[tomchristie]

Verified. Previously we were relying on the default value of TEMPLATE_CONTEXT_PROCESSORS, which includes django.contrib.auth.context_processors.auth.

We could add this in to the TEMPLATES.OPTIONS.context_processors in conftest.py, which would resolve our test cases, but it's better if we pass it explicitly, and not rely on the user settings.

[codecov-io]

Current coverage is 91.47%

Merging #4158 into master will decrease coverage by <.01%

@@             master      #4158   diff @@
==========================================
  Files            51         51          
  Lines          5483       5487     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           5016       5019     +3   
- Misses          467        468     +1   
  Partials          0          0          

Powered by Codecov. Last updated by fe2aede...c65c5e4

[tomchristie]

There's an outstanding issue, downstream in django-filters, which uses get_field_by_name which does not exist across all versions. Once that's resolved we can remove the "expected failure" marker.

ERROR collecting tests/test_filters.py
=====================
tests/test_filters.py:40: in <module>
    class SeveralFieldsFilter(django_filters.FilterSet):
env/lib/python2.7/site-packages/django_filters/filterset.py:197: in __new__
    new_class.filter_for_reverse_field)
env/lib/python2.7/site-packages/django_filters/filterset.py:111: in filters_for_model
    field = get_model_field(model, f)
env/lib/python2.7/site-packages/django_filters/filterset.py:93: in get_model_field
    rel, model, direct, m2m = opts.get_field_by_name(parts[-1])
E   AttributeError: 'Options' object has no attribute 'get_field_by_name'

In the meantime there's no reason not to merge this now, as it resolves almost all our issues, and the remaining failure is in the "expected failures" matrix.

[carltongibson]

I'll pick that up.

[tomchristie]

👍 Let me know if you want some of my time, too.

[carltongibson]

Only if it's hard. :-) — It should be OK.