Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle OverflowError in DurationField deserialization #8042

Merged

Conversation

peterthomassen
Copy link
Contributor

Related: https://github.com/django/django/pull/8870/files

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Properly handle OverflowError in DurationField deserialization. Solution is the same as for the corresponding Django form field.

@stale
Copy link

stale bot commented Apr 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 25, 2022
@peterthomassen
Copy link
Contributor Author

I think this is still current.

@stale stale bot removed the stale label Apr 25, 2022
@stale
Copy link

stale bot commented Jul 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2022
@peterthomassen
Copy link
Contributor Author

I think this is still current.

@stale stale bot removed the stale label Jul 14, 2022
@stale
Copy link

stale bot commented Sep 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 22, 2022
@peterthomassen
Copy link
Contributor Author

I think this is still current.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have recently merged an identical feature for another field #8725. can you cross check and make amendment accordingly to this PR?

@stale stale bot removed the stale label Nov 22, 2022
@peterthomassen
Copy link
Contributor Author

The code looks very similar to me. Which according amendments do you mean? (Would you like to change the logic, or the error message? (Number of days out of range, must be between {min_days} and {max_days}.)

@auvipy
Copy link
Member

auvipy commented Nov 22, 2022

btw, having another look, it seems your code is quite right. can you please pull from master so that the CI triggers with latest changes?

@peterthomassen peterthomassen force-pushed the 20210618_DurationField_validation branch from 5c97c3b to 86d46c9 Compare November 22, 2022 15:43
@peterthomassen peterthomassen force-pushed the 20210618_DurationField_validation branch from c458456 to c6eb872 Compare November 22, 2022 15:44
@peterthomassen
Copy link
Contributor Author

done

@auvipy auvipy added the Bug label Nov 24, 2022
@auvipy auvipy merged commit 52f4139 into encode:master Nov 24, 2022
@auvipy
Copy link
Member

auvipy commented Nov 24, 2022

thank you for your patience

@peterthomassen peterthomassen deleted the 20210618_DurationField_validation branch November 24, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants