Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type check tests #1054

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Type check tests #1054

merged 2 commits into from
Jul 7, 2020

Conversation

florimondmanca
Copy link
Member

Closes #650

Finally get us to enable mypy on tests/ :-)

This PR consists in:

  • Updating scripts/check so that mypy is also run on the tests/ directory.
  • Fixing or silencing any type errors in tests to make mypy pass.

@florimondmanca florimondmanca added the tooling Changes to our CI/CD, tests setup, etc. label Jul 7, 2020
@florimondmanca florimondmanca requested a review from a team July 7, 2020 08:17
tomchristie
tomchristie approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. 👍

@florimondmanca florimondmanca merged commit 0296c2b into master Jul 7, 2020
@florimondmanca florimondmanca deleted the typed-tests branch July 7, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
tooling Changes to our CI/CD, tests setup, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type-checking our tests
2 participants
@florimondmanca @tomchristie