Move test server to a separately importable module #990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #650, prompted by #985 (comment)
Being able to import the test
Server
is required* for annotating tests.*At least, it's required with our current test setup. Dunno if we might want to consider tweaking our mypy configuration with
--check-untyped-defs
, so that the inside of test functions is type checked even though their signature is not annotated. In general it's really the inside of tests (calls to HTTPX) that we want to make sure provide a good typing experience — type hinting the test function signatures doesn't provide a huge gain (but on the contrary a non-negligible amount of work is required if we did want to annotate them all).So, marking this as a draft for now…