Add 400 response on MultiParser exceptions #1593
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boundary
#1588Let's call this solution 1.
Why I don't like solution 1:
ExceptionMiddleware
, which is weird.Possible solution 2:
HTTPException
with import inside theMultiPartParser
to avoid circular import.Possible solution 3:
http_exception.py
file to hold onlyHTTPException
, and import it onexceptions.py
andformparsers.py
.I'm exposing this draft as a self note. Solution 3 looks like the best one.