Support Python 3.13 #2662
Merged
Support Python 3.13 #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Kludex
commented
Aug 6, 2024
starlette/middleware/gzip.py
Outdated
| @@ -42,6 +42,7 @@ def __init__(self, app: ASGIApp, minimum_size: int, compresslevel: int = 9) -> N | |||
| async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: | |||
| self.send = send | |||
| await self.app(scope, receive, self.send_with_gzip) | |||
| self.gzip_file.close() | |||
There was a problem hiding this comment.
@graingert Is this good enough?
There was a problem hiding this comment.
You might want to do it in a finally, or even better use with
with BytesIO() as buffer, GzipFile(..., buffer) as gzip_file:
await self.app(scope, receive, functools.partial(self.send_with_gzip, buffer, gzip_file))
|
I tried this PR as a patch for I do like @graingert’s suggestion in #2662 (comment), though. |
adriangb
approved these changes
Aug 6, 2024
graingert
approved these changes
Aug 6, 2024
nixroxursox
pushed a commit
to nixroxursox/starlette
that referenced
this pull request
Sep 30, 2024
* Support Python 3.13 * Use `exc_type_str` instead of `exc_type.__name__` * Close GzipFile * min changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.