Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query asset fee details #244

Merged
merged 11 commits into from
Aug 14, 2022
Merged

Query asset fee details #244

merged 11 commits into from
Aug 14, 2022

Conversation

pifragile
Copy link
Contributor

@pifragile pifragile commented Jul 27, 2022 •
edited by clangenb
Loading

Node part of encointer/pallets#248

@pifragile pifragile requested a review from clangenb July 27, 2022 13:49
clangenb
clangenb approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, looks good codewise, but I have not tested it. You can remove the patches now, I have merged the corresponding pallet PR.

@clangenb
Copy link
Member

clangenb commented Aug 14, 2022 •
edited
Loading

The output does not look good yet:

[DEBUG encointer_client_notee::utils] account can pay fees in CC: fee: 8629800000000000 bal: 0.9999986478879682557

@clangenb
Copy link
Member

clangenb commented Aug 14, 2022 •
edited
Loading

I fixed the human readable output. It looks like a sensible value now:

[DEBUG encointer_client_notee::utils] account can pay fees in CC: fee: 0.00862979999999999997 bal: 0.5

@clangenb clangenb merged commit cd91db4 into master Aug 14, 2022
@clangenb clangenb deleted the query-asset-fee-details branch August 21, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pifragile @clangenb