add TrustableForNonDestructiveAction #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
requested changes
Aug 13, 2022
runtime/src/lib.rs
Outdated
| @@ -440,6 +440,7 @@ impl pallet_encointer_ceremonies::Config for Runtime { | |||
| impl pallet_encointer_communities::Config for Runtime { | |||
| type Event = Event; | |||
| type CommunityMaster = EnsureRoot<AccountId>; | |||
| type TrustableForNonDestructiveAction = EnsureRoot<AccountId>; | |||
There was a problem hiding this comment.
This is meant to be 'EnsureSigned' AKA 'anyone who pays fees' because in the case of solochains (Gesell) we want to be permissive
There was a problem hiding this comment.
Please test in CI e2e that anyone can register a community
There was a problem hiding this comment.
oh ok, i wasn't sure about that and i wanted to be conservative with security :) does that generally mean that everything in node/runtime will only ever be run on testnets?
There was a problem hiding this comment.
This is true only for the node though. The parachain is productive by default.
|
@pifragile please ensure that your branch is up to date when you request my review. I first want to see CI passing respective to master |
brenzi
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node side of encointer/pallets#255