Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encointer-Testnet to run with encointer community-sidechain #283

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

echevrier
Copy link
Collaborator

  • Add Integritee teerex and sidechain pallets
  • Add skip-ias-check feature

echevrier added 3 commits December 8, 2022 16:01
Add skip-ias-check feature

Add NonZero sender
integritee pallet to branch develop: compatible with worker
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question, but it looks good otherwise

Comment on lines +29 to +30
pallet-sidechain = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "develop" }
pallet-teerex = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "develop" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose the develop branch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, when I did it ;)
As the pallet mastrer branch is fixed, I will change it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think polkadot-v.0.9.28 is only working with the develop branch. So we should change it when we do a polkadot upgrade

Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@clangenb clangenb merged commit c324f6e into community-sidechain Dec 8, 2022
@clangenb clangenb deleted the ec/cantillon_test_node branch December 20, 2022 11:52
OverOrion pushed a commit that referenced this pull request Aug 9, 2023
* Add Integritee Teerex and Sidechain pallet in the runtime

Add skip-ias-check feature

Add NonZero sender
integritee pallet to branch develop: compatible with worker

* Readme: tesnet cantillon

* Update Readme

* add comment

Co-authored-by: echevrier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants