-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encointer-Testnet to run with encointer community-sidechain #283
Conversation
echevrier
commented
Dec 8, 2022
- Add Integritee teerex and sidechain pallets
- Add skip-ias-check feature
Add skip-ias-check feature Add NonZero sender integritee pallet to branch develop: compatible with worker
05366ae
to
4a0a5e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question, but it looks good otherwise
pallet-sidechain = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "develop" } | ||
pallet-teerex = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "develop" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this on purpose the develop branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was, when I did it ;)
As the pallet mastrer branch is fixed, I will change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think polkadot-v.0.9.28 is only working with the develop branch. So we should change it when we do a polkadot upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now!
* Add Integritee Teerex and Sidechain pallet in the runtime Add skip-ias-check feature Add NonZero sender integritee pallet to branch develop: compatible with worker * Readme: tesnet cantillon * Update Readme * add comment Co-authored-by: echevrier <[email protected]>