[client] support AnnouncementSigner and CommunityRules in the spec files
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
force-pushed
the
cl/add-community-rules-support
branch
from
b2f9458 to
2024acd
Compare
brenzi
reviewed
Sep 15, 2023
brenzi
requested changes
Sep 15, 2023
|
I updated the locolight community to Corsica and put The below is taken from a local node, not Gesell.
|
clangenb
commented
Sep 18, 2023
Comment on lines
+12
to
+17
| "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY", | ||
| "5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty", | ||
| "5FLSigC9HGRKVhB9FiEo4Y3koPsNmBmLJbpXg2mp1hXcS59Y", | ||
| "5DAAnrj7VHTznn2AWBemMuyBwZWs6FNFjdyVXUeYum3PTXFy", | ||
| "5HGjWAeFDfFCWPsjFQdVV2Msvz2XtMktvgocEZcCj68kUMaw", | ||
| "5CiPPseXPECbkjWCa6MnjNokrgYjMqmKndv2rSnekmSK2DjL" |
| "name": "Corsica LoCoLight", | ||
| "symbol": "CLL", | ||
| "assets": "QmP2fzfikh7VqTu8pvzd2G2vAd4eK7EaazXTEgqGN6AWoD", | ||
| "announcementSigner": {"bip340": "0xceda72c19f11aebecf8fb4a0ab3fb2a03e03f283225655baab4728303a560a13"}, |
…ht` in spec file.
…ter handling of the announcement signer.
…chain spec, such that we can parse them.
brenzi
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
well, not happy about camelCase as options would exist to change this behavior. But you may be right that we have less trouble like this.
Also I thought we already refactored LoCoLight to LoCoFlex, which we didn't. but as this is an internal value, I don't think its painful to do that later
|
Oh, I did not know that should have been refactored to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnouncementSignerandLoCoLightrules. The bootstrappers are Alice to Ferdie and Alice is the announcement signer.LoCoLighttoLoCoFlex.