Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/daemon/run: avoid double-reporting parse errors #1482

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

eandre
Copy link
Member

@eandre eandre commented Oct 14, 2024

This wasn't a big problem for Go errors as we only
reported the first line, but it was problematic for TypeScript
errors which duplicated the full error output.

This wasn't a big problem for Go errors as we only
reported the first line, but it was problematic for TypeScript
errors which duplicated the full error output.
@encore-cla
Copy link

encore-cla bot commented Oct 14, 2024

All committers have signed the CLA.

@eandre eandre requested a review from ekerfelt October 14, 2024 16:14
@eandre eandre enabled auto-merge (squash) October 14, 2024 16:14
@eandre eandre disabled auto-merge October 15, 2024 14:29
@eandre eandre merged commit 74231a0 into encoredev:main Oct 15, 2024
4 checks passed
@eandre eandre deleted the double-error-report-fix branch October 15, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants