Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimes/js: fix tsc syntax issues, improve packaging #1493

Merged
merged 1 commit into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions runtimes/js/encore.dev/internal/api/node_http.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class RawRequest extends stream.Readable {
this.body.start(this.push.bind(this), this.destroy.bind(this));

// Set the socket to a dummy value for legacy compatibility with Express.js.
this.socket = new DummySocket();
this.socket = new DummySocket() as Socket;
this.connection = this.socket; // legacy alias
}

Expand Down Expand Up @@ -136,7 +136,7 @@ export class RawResponse extends stream.Writable {
this.w = w;

// Set the socket to a dummy value for legacy compatibility with Express.js.
this.socket = new DummySocket();
this.socket = new DummySocket() as Socket;
this.connection = this.socket; // legacy alias
}

Expand Down
3 changes: 3 additions & 0 deletions runtimes/js/encore.dev/internal/runtime/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Intentionally left blank, because we want the napi directory
# to be included in packages, but we don't want it committed to the repository.
# If this file does not exist then the npm packaging code will use the .gitignore file instead.
2 changes: 2 additions & 0 deletions runtimes/js/encore.dev/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@
"dist/",
"*.ts",
"**/*.ts",
"*.cjs",
"*.cts",
"README.md",
"LICENSE"
],
Expand Down
Loading