Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: catch invalid migration numbers #945

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

eandre
Copy link
Member

@eandre eandre commented Nov 19, 2023

It was incorrectly removed in a refactoring. Also support unnamed
migrations while we're at it, which is common when using tools like
Atlas to generate migrations.

@encore-cla
Copy link

encore-cla bot commented Nov 19, 2023

All committers have signed the CLA.

Verified

This commit was signed with the committer’s verified signature.
eason9487 Eason
It was incorrectly removed in a refactoring. Also support unnamed
migrations while we're at it, which is common when using tools like
Atlas to generate migrations.
@eandre eandre force-pushed the parser-invalid-migrations branch from f45b2e1 to 032e6dc Compare November 19, 2023 17:21
Copy link

Test Results

    2 files  +       1  227 suites  +65   7m 19s ⏱️ - 22m 3s
716 tests +   185  713 ✔️ +   193  3 💤 +3  0  - 2 
716 runs   - 1 863  713 ✔️  - 1 855  3 💤 +3  0  - 2 

Results for commit 032e6dc. ± Comparison against base commit 58765d3.

This pull request removes 17 and adds 202 tests. Note that renamed tests count towards both.
encr.dev/e2e-tests ‑ TestRun/encore_currentrequest
encr.dev/e2e-tests ‑ TestRun/et_override_user
encr.dev/e2e-tests ‑ TestRun/et_override_user_authdata
encr.dev/e2e-tests ‑ TestRun/experiment_local_secrets_override
encr.dev/e2e-tests ‑ TestRun/fallback_routes
encr.dev/e2e-tests ‑ TestRun/graceful_shutdown
encr.dev/e2e-tests ‑ TestRun/pubsub_method_handler
encr.dev/e2e-tests ‑ TestRun/pubsub_ref
test/svc ‑ TestRun
test/svc ‑ TestRun/encore_currentrequest
…
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/echo
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/invalid
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/raw
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/echo
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/invalid
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestRawEndpointOverflow
…

@eandre eandre requested a review from DomBlack November 19, 2023 17:28
@eandre eandre enabled auto-merge (rebase) November 19, 2023 18:35
@eandre eandre merged commit f3cb841 into encoredev:main Nov 20, 2023
5 checks passed
@eandre eandre deleted the parser-invalid-migrations branch November 20, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants