Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dash: propagate app id for new trace events #960

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

eandre
Copy link
Member

@eandre eandre commented Nov 29, 2023

No description provided.

@encore-cla
Copy link

encore-cla bot commented Nov 29, 2023

All committers have signed the CLA.

@eandre eandre requested a review from DomBlack November 29, 2023 09:46
Copy link

Test Results

    2 files  +       1  227 suites  +65   7m 15s ⏱️ - 5m 52s
716 tests +   184  713 ✔️ +   193  3 💤 +3  0  - 3 
716 runs   - 1 864  713 ✔️  - 1 855  3 💤 +3  0  - 3 

Results for commit 2fe455f. ± Comparison against base commit f7880d8.

This pull request removes 18 and adds 202 tests. Note that renamed tests count towards both.
encr.dev/e2e-tests ‑ TestRun/encore_currentrequest
encr.dev/e2e-tests ‑ TestRun/et_override_user
encr.dev/e2e-tests ‑ TestRun/et_override_user_authdata
encr.dev/e2e-tests ‑ TestRun/experiment_local_secrets_override
encr.dev/e2e-tests ‑ TestRun/fallback_routes
encr.dev/e2e-tests ‑ TestRun/graceful_shutdown
encr.dev/e2e-tests ‑ TestRun/pubsub_method_handler
encr.dev/e2e-tests ‑ TestRun/pubsub_ref
test/svc ‑ TestProcClosedOnCtxCancel
test/svc ‑ TestRun
…
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/echo
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/invalid
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/raw
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/echo
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/invalid
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestRawEndpointOverflow
…

@eandre eandre merged commit 6c38020 into encoredev:main Dec 7, 2023
4 of 5 checks passed
@eandre eandre deleted the app-trace-notifs branch December 7, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants