Summary and pin function #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DoomTas3r thanks! There is a bounty for the duplicate functionality. Please follow the steps in #201 (comment) if you would like to attempt it. |
|
Thanks, but I will not accept or claim the bounty |
|
@DoomTas3r I see that you are trying to add pin functionality to this PR as well, which was never discussed. My suggestion is to try contributing smaller chunks, because they are more likely to be merged. For example I would start with a context menu and just the current Delete functionality that is already there (as Del key shortcut). |
DoomTas3r
changed the title
DoomTas3r
force-pushed
the
context-menu
branch
3 times, most recently
from
4225006 to
a5249a0
Compare
Adds a context menu with duplicate, summary, pin, and delete functions with shortcuts ctrl + d to duplicate, ctrl + p to pin. Duplicate and pin affects snapped blocks. Context menu displays when drag drop area receives a right click
DoomTas3r
force-pushed
the
context-menu
branch
from
bfdbb9e to
8249281
Compare
|
@DoomTas3r the Duplicate and Delete has been merged. If you still want to discuss pin functionality, please open a issue. Closing this for now! |
DoomTas3r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds summary and pin to the context menu
The summary shows the tooltip of the block, intended to be replaced by a more detailed overview like #291 (comment)
Adds a pin function with
ctrl + pas a shortcut. Pinned blocks can't be dragged. Snapped blocks can pin with their parent block. This feature doesn't need to be added because the undo feature can undo the effects of accidental drags or deletes, so this is just for convenience