Added advanced mode #337
Added advanced mode #337
Conversation
There was a problem hiding this comment.
This is working! Except for a bug I've found and a check failing. I tried it with the "every physics step" block from PR #262 and then marking the "is advanced" option on it.
Grabación de pantalla desde 2024-12-16 09-44-58.webm
Please fix the bug above and also make the "linting and formatting" check pass. You can run the checks locally if you setup pre-commit as the README explains.
|
Thanks for the review @manuq, I setup pre-commit which fixed the linter errors and I also fixed the bug where adding a new Variable removes the advanced blocks. |
There was a problem hiding this comment.
Looks good now, @urbit-pilled . We try to have descriptive commit messages in this project. Could you squash your commits and provide a good description? For example:
- A first line explaining briefly what's this about.
- A description of what does this PR do and how it's implemented.
- As last line, the URL to the issue that this fixes, eg "Fixes https://..."
Then we'll be able to merge.
This adds an advanced mode to the title dock that allows the user to see advanced blocks, which will help us add advanced blocks without cluttering the block list. I implemented it by: - adding `is_advanced` boolean to the `BlockDefinition` class and set the default value to false. - adding an "advanced" checkbox to `main_panel.tscn` - modifying `picker.gd` to filter the block list to hide advanced blocks if the checkbox is unchecked. Fixes endlessm#282
IntegerOverfl0w
force-pushed
the
add_advanced
branch
from
9b0130e to
6571f15
Compare
|
Thanks for the help @manuq, I squashed the commits and provided a more detailed commit message so it should be ready to merge now. |
Thanks for your contribution! The commit message is very good now. |
/claim #282
is_advancedboolean to the block_definition (default value is false)