p4a: Add metadata to maximize window #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect jenkins to fail as this depends on endlessm/python-for-android#5 being merged and pinned in the Makefile. |
|
Hmm, jenkins failed saying p4a was missing the option, but that seems wrong. Let's try that again. |
|
retest this please |
1 similar comment
|
retest this please |
|
Ohh... it's because |
|
retest this please |
|
Yep, it succeeded after I manually deleted the docker volume being used as the p4a cache. |
|
Can we look at #39 (the last commit in particular) before merging this so that the normal build doesn't break reusing the wrong p4a? |
|
#39 got merged, so taking this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T33607