Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make iconSlug explicit for all products #2085

Closed
marcwrobel opened this issue Dec 17, 2022 · 1 comment · Fixed by #2087
Closed

Make iconSlug explicit for all products #2085

marcwrobel opened this issue Dec 17, 2022 · 1 comment · Fixed by #2087
Labels
enhancement New feature or request

Comments

@marcwrobel
Copy link
Member

Currently iconSlug is optional : if a product does not declare one, a default value is generated using the permalink. Being explicit is better and causes less confusion.

iconSlug must be made mandatory without a default value, and its presence must be enforced (by https://github.com/endoflife-date/endoflife.date/blob/master/_auto/validate.py).
@marcwrobel
Copy link
Member Author

Relates to #759.

marcwrobel added a commit that referenced this issue Dec 18, 2022
@marcwrobel
Make iconSlug explicit for all products (closes #2085)
555a0a0 
Being explicit is simpler (especially on API side, see #759) and causes less confusion.
@marcwrobel marcwrobel linked a pull request Dec 18, 2022 that will close this issue
Make iconSlug explicit for all products #2087
Merged
marcwrobel added a commit that referenced this issue Dec 19, 2022
@marcwrobel
Make iconSlug explicit for all products (closes #2085)
ea0648d 
Being explicit is simpler (especially on API side, see #759) and causes less confusion.
@marcwrobel marcwrobel mentioned this issue Dec 19, 2022
Merged
@marcwrobel marcwrobel added the enhancement New feature or request label Dec 19, 2022
captn3m0 pushed a commit that referenced this issue Dec 20, 2022
@marcwrobel @captn3m0
Make iconSlug explicit for all products (closes #2085)
60e7f9c 
Being explicit is simpler (especially on API side, see #759) and causes less confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make iconSlug explicit for all products endoflife-date/endoflife.date
1 participant
@marcwrobel