Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup _redirects template #2135

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Cleanup _redirects template #2135

merged 1 commit into from
Dec 26, 2022

Conversation

marcwrobel
Copy link
Member

  • improve documentation,
  • remove extra empty line in the rendered file,
  • don't generate API redirects for non-product pages.

@marcwrobel
Cleanup _redirects template
6dd138a 
- improve documentation,
- remove extra empty line in the rendered file,
- don't generate API redirects for non-product pages.
@marcwrobel marcwrobel requested a review from captn3m0 December 22, 2022 13:18
@marcwrobel marcwrobel changed the title Cleanup _redirects template Cleanup _redirects template Dec 22, 2022
captn3m0
captn3m0 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated diff for _redirects. We drop from 585 -> 564 redirects.

@marcwrobel marcwrobel merged commit 28f5adb into master Dec 26, 2022
@marcwrobel marcwrobel deleted the cleanup-redirects-template branch December 26, 2022 18:34
@marcwrobel marcwrobel added the enhancement New feature or request label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captn3m0 captn3m0 captn3m0 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcwrobel @captn3m0