Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: introduceNamesToParty should be awaited #2121

Closed
rekmarks opened this issue Mar 8, 2024 · 2 comments · Fixed by #2138
Closed

daemon: introduceNamesToParty should be awaited #2121

rekmarks opened this issue Mar 8, 2024 · 2 comments · Fixed by #2138
Labels
bug Something isn't working

Comments

@rekmarks
Copy link
Contributor

rekmarks commented Mar 8, 2024

Following #2120, we should ensure that introduceNamesToParty is always awaited.
@rekmarks rekmarks added the bug Something isn't working label Mar 8, 2024
@rekmarks
Copy link
Contributor Author

rekmarks commented Mar 8, 2024

@kriskowal should introductions be synchronized? They are not currently, but if new parties expect their introduced names to be immediately available, they should be.

@rekmarks rekmarks mentioned this issue Mar 8, 2024
Merged
@kriskowal
Copy link
Member

@kriskowal should introductions be synchronized? They are not currently, but if new parties expect their introduced names to be immediately available, they should be.

I would expect names to be available to the guest the moment the guest is mentionable.

@rekmarks rekmarks mentioned this issue Mar 13, 2024
Merged
rekmarks added a commit that referenced this issue Mar 14, 2024
@rekmarks
refactor!(daemon): Synchronize makeHost() (merge #2138)
55b5909 
Progresses: #2086 
Fixes: #2121 

Synchronizes `makeHost()` and its dependent functions. Also refactors the same and `makeGuest()` to extract their commonalities and restore the more succinct form they possessed before the synchronization effort began. As part of the refactor, #2121 was fixed.

From this point onward, we will start referring to endo "agents" instead of "parties".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!(daemon): Synchronize makeHost() endojs/endo
2 participants
@kriskowal @rekmarks