chore(nat): Fix typo in Nat error message #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just grepped for "not a safe integer" and verified that none of our endo or agoric-sdk code should have a problem with this change. This change also makes the error more consistent with other errors in agoric-sdk https://github.com/Agoric/agoric-sdk/blob/cc2bf0bb431aa64c601628f53cf191fcc84c5750/packages/ERTP/src/displayInfo.js#L26 |
gibson042
force-pushed
the
2024-05-fix-nat-error-message
branch
from
9b8be33 to
e432313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a missing "is" to an error message from
Nat.Security Considerations
None.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
None.
Compatibility Considerations
n/a
Upgrade Considerations
We expect error messages to change over time and require code to be tolerant of this.