chore: Fix browser tests #2686
Merged
chore: Fix browser tests #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Jan 10, 2025
leotm
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
- fixes Flakey browser tests (playwright) #2660 (updated description)
- (supersedes) closes ci: fix browser-tests ubuntu 24.04 compat #2587
|
@kriskowal I'd like to put some pressure on making it non-optional because the fix was trivial and its coverage of important SES compatibility is going to increase: I've added coverage for CSP and also a convenient display of new intrinsics SES is deleting in each browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser tests are failing to install browsers for playwright since ubuntu version was updated in the runners.
Updating playwright seems to fix it.
They've been failing for a while. Do we need the failure to be more prominent?
Fixes: #2660