pay: ignore uncommited channels in listpeerchannels output

Uncommited channels are missing several fields which would normally be
populated by an active channel.  This simply skips them for the purposes
of finding a route.  The particular culprit was:
{
  "peer_id": "038cd9f3679d5b39bb2105978467918d549572de472f07dd729e37c7a6377d41d5",
  "peer_connected": true,
  "state": "OPENINGD",
  "owner": "lightning_openingd",
  "opener": "local",
  "to_us_msat": 8317559000,
  "total_msat": 8317559000,
  "features": [
    "option_static_remotekey",
    "option_anchors_zero_fee_htlc_tx"
  ]
}

Fixes ElementsProject#7197 - SEGV in direct_pay_listpeerchannels when field private missing

Changelog-Fixed: Fixed crash in pay plugin caused by parsing uncommitted dual open channels

plugins/libplugin.c

@@ -2113,6 +2113,11 @@ static struct listpeers_channel *json_to_listpeers_channel(const tal_t *ctx,
 
 	chan = tal(ctx, struct listpeers_channel);
 
+	/* If we catch a channel during opening, these might not be set.
+	 * It's not a real channel (yet), so ignore it! */
+	if (!chan->scid && !chan->alias[LOCAL])
+		return tal_free(chan);
+
 	json_to_node_id(buffer, idtok, &chan->id);
 	json_to_bool(buffer, conntok, &chan->connected);
 	json_to_bool(buffer, privtok, &chan->private);
@@ -2149,11 +2154,6 @@ static struct listpeers_channel *json_to_listpeers_channel(const tal_t *ctx,
 		chan->alias[REMOTE] = NULL;
 	}
 
-	/* If we catch a channel during opening, these might not be set.
-	 * It's not a real channel (yet), so ignore it! */
-	if (!chan->scid && !chan->alias[LOCAL])
-		return tal_free(chan);
-
 	json_to_int(buffer, dirtok, &chan->direction);
 	json_to_msat(buffer, tmsattok, &chan->total_msat);
 	json_to_msat(buffer, smsattok, &chan->spendable_msat);

tests/test_pay.py

@@ -5590,7 +5590,6 @@ def test_pay_partial_msat(node_factory, executor):
     l3pay.result(TIMEOUT)
 
 
-@pytest.mark.xfail(strict=True)
 def test_pay_while_opening_channel(node_factory, bitcoind, executor):
     delay_plugin = {'plugin': os.path.join(os.getcwd(),
                                            'tests/plugins/openchannel_hook_delay.py'),