-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: publish assets on-chain #654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitneypurdum
force-pushed
the
#SWTCH-1465
branch
from
September 12, 2022 11:20
9a818a3
to
7209998
Compare
whitneypurdum
commented
Sep 12, 2022
whitneypurdum
commented
Sep 12, 2022
jrhender
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @whitneypurdum
whitneypurdum
added a commit
that referenced
this pull request
Sep 20, 2022
* fix(infura): replace config with ipfs daemon for initUser methods * fix: update agreer for subjectAgreementCheck * fix: update test to register asset * fix: always use subject for subjectAgreement * fix: remove mock for getting assets * fix: remove unused asset wallet * fix: use subject
🎉 This PR is included in version 7.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ewf-devops
pushed a commit
that referenced
this pull request
Dec 6, 2022
## [7.0.0](v6.2.0...v7.0.0) (2022-12-06) ### ⚠ BREAKING CHANGES * **claims:** Payload of selfsigned claim is arbitrary object ### Bug Fixes * bump ew-credentials to 2.2.1-alpha.296.0 ([#662](#662)) ([9af689c](9af689c)) * **claims:** change selfsigned claim to record ([9986876](9986876)) * commit for 2c0a860 ([45cdac0](45cdac0)) * publish assets on-chain ([#654](#654)) ([2c0a860](2c0a860)) * verify credential before issuer verification ([111923b](111923b)) ### Refactoring * **claims:** merge ClaimData with vc-verification ([0e1fafa](0e1fafa)) ### Documentation * add asset credential registration to documentation ([ba6f7ba](ba6f7ba)) ### Style changes * add warn for shadow variables (variables in scope that share s… ([#663](#663)) ([dd28b49](dd28b49))
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug for missing subjectAgreement when publishing assets on-chain
Contributor checklist