Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: publish assets on-chain #654

Merged
merged 12 commits into from
Sep 19, 2022
Merged

Fix: publish assets on-chain #654

merged 12 commits into from
Sep 19, 2022

Conversation

whitneypurdum
Copy link
Contributor

@whitneypurdum whitneypurdum commented Sep 12, 2022

Description

Fix bug for missing subjectAgreement when publishing assets on-chain

Contributor checklist

  • Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
  • Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
  • Tests - add new or updated existed test for changes you made.
  • Migration guide - add migration guide for every breaking change.
  • Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

@whitneypurdum whitneypurdum marked this pull request as draft September 13, 2022 12:48
@whitneypurdum whitneypurdum changed the title #swtch 1465 Fix: publish assets on-chain Sep 16, 2022
@whitneypurdum whitneypurdum marked this pull request as ready for review September 16, 2022 20:04
Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @whitneypurdum

@whitneypurdum whitneypurdum merged commit 2c0a860 into develop Sep 19, 2022
whitneypurdum added a commit that referenced this pull request Sep 20, 2022
* fix(infura): replace config with ipfs daemon for initUser methods

* fix: update agreer for subjectAgreementCheck

* fix: update test to register asset

* fix: always use subject for subjectAgreement

* fix: remove mock for getting assets

* fix: remove unused asset wallet

* fix: use subject
ewf-devops pushed a commit that referenced this pull request Sep 21, 2022
## [7.0.0-alpha.2](v7.0.0-alpha.1...v7.0.0-alpha.2) (2022-09-21)

### Bug Fixes

* commit for 2c0a860 ([45cdac0](45cdac0))
* publish assets on-chain ([#654](#654)) ([2c0a860](2c0a860))

### Documentation

* add asset credential registration to documentation ([ba6f7ba](ba6f7ba))
@ewf-devops
Copy link

🎉 This PR is included in version 7.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

ewf-devops pushed a commit that referenced this pull request Dec 6, 2022
## [7.0.0](v6.2.0...v7.0.0) (2022-12-06)

### ⚠ BREAKING CHANGES

* **claims:** Payload of selfsigned claim is arbitrary object

### Bug Fixes

* bump ew-credentials to 2.2.1-alpha.296.0 ([#662](#662)) ([9af689c](9af689c))
* **claims:** change selfsigned claim to record ([9986876](9986876))
* commit for 2c0a860 ([45cdac0](45cdac0))
* publish assets on-chain ([#654](#654)) ([2c0a860](2c0a860))
* verify credential before issuer verification ([111923b](111923b))

### Refactoring

* **claims:** merge ClaimData with vc-verification ([0e1fafa](0e1fafa))

### Documentation

* add asset credential registration to documentation ([ba6f7ba](ba6f7ba))

### Style changes

* add warn for shadow variables (variables in scope that share s… ([#663](#663)) ([dd28b49](dd28b49))
@ewf-devops
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants