Skip to content

Commit

Permalink
[two_dimensional_scrollables] Post 3.16 stable tech debt clean up (fl…
Browse files Browse the repository at this point in the history
…utter#5671)

Fixes flutter#136933
Fixes flutter#132782

This cleans up some TODOs in the TableView and its tests after the stable release
- removes an assertion on the builder delegate bounds now that the super class handles the assertions
- refactors all of the golden file tests using PaintPattern, removing all of the golden files and enabling web testing
  • Loading branch information
Piinks authored Dec 14, 2023
1 parent 1151191 commit 77579ba
Show file tree
Hide file tree
Showing 7 changed files with 240 additions and 104 deletions.
3 changes: 0 additions & 3 deletions packages/two_dimensional_scrollables/dart_test.yaml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ class TableCellBuilderDelegate extends TwoDimensionalChildBuilderDelegate
int get columnCount => maxXIndex! + 1;
set columnCount(int value) {
assert(pinnedColumnCount <= value);
// TODO(Piinks): remove once this assertion is added in the super class
assert(value >= -1);
maxXIndex = value - 1;
}

Expand Down Expand Up @@ -180,8 +178,6 @@ class TableCellBuilderDelegate extends TwoDimensionalChildBuilderDelegate
int get rowCount => maxYIndex! + 1;
set rowCount(int value) {
assert(pinnedRowCount <= value);
// TODO(Piinks): remove once this assertion is added in the super class
assert(value >= -1);
maxYIndex = value - 1;
}

Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading

0 comments on commit 77579ba

Please sign in to comment.