Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHI-4789 - Build the cookiejar gem from sources #135

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

eudalov
Copy link
Contributor

@eudalov eudalov commented Sep 25, 2023

The fix for https://github.com/trilogy-group/eng-maintenance/issues/4789.

The external gem cookiejar (which is referred from faye) of the latest published version 0.3.3 which is available on rubygems.org has not all fixes from the master banch, repo https://github.com/dwaite/cookiejar. We need one of them regarding the support of the samesite cookie. But the updates won't be published as the work on the gem has been suspended and the repo is archived now.
I reconfigured to get cookiejar not from the rubygems.org but from the source code. This has fixed the problem with samesite cookie.

@dvalfre dvalfre self-requested a review September 26, 2023 13:38
@eudalov eudalov changed the title GHI-4789 - ey-core deploy verbose not working GHI-4789 - Build the cookiejar gem from sources Oct 25, 2023
@eudalov eudalov merged commit 7a181d0 into engineyard:develop Oct 26, 2023
@eudalov eudalov deleted the bugfix/GHI-4789 branch October 26, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants