GHI-4789 - Build the cookiejar
gem from sources
#135
Merged
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for https://github.com/trilogy-group/eng-maintenance/issues/4789.
The external gem
cookiejar
(which is referred fromfaye
) of the latest published version 0.3.3 which is available onrubygems.org
has not all fixes from themaster
banch, repo https://github.com/dwaite/cookiejar. We need one of them regarding the support of thesamesite
cookie. But the updates won't be published as the work on the gem has been suspended and the repo is archived now.I reconfigured to get
cookiejar
not from therubygems.org
but from the source code. This has fixed the problem withsamesite
cookie.