Bump MSRV and Rust edition #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentamassiv
force-pushed
the
bump_msrv
branch
2 times, most recently
from
e6d5f01 to
8a1fb6b
Compare
pentamassiv
force-pushed
the
bump_msrv
branch
from
68c7655 to
c4f2418
Compare
|
Everything looks okay, except there is a compiler bug on macOS Nightly. This is blocking the merge. We need to wait for it to get fixed. I did not report the issue upstream yet, because they ask for a specific file from the runner, which I can only access if I change the workflow. |
pentamassiv
force-pushed
the
bump_msrv
branch
from
c4f2418 to
c394bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Rust edition
2024was released. In order to use it, the MSRV had to be bumped to 1.85.The Drop behavior of temporary values was changed. I was notified that the Drop behavior in the libei code was affected by this. For more, see https://doc.rust-lang.org/nightly/edition-guide/rust-2024/temporary-tail-expr-scope.html