Etherbone testing #106
Open
Etherbone testing #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for analysis with wireshark
* only send a ping reply to type 8 (ping request) packets
* otherwise liteeth would send a ping reply to
`destination unreachable` packets too, which is not wanted
there is a liteeth problem with the ping replies
also, add checks to ICMP testbench
also: it should be able to digest bytes and convert them to dw sized words on its own
test_icmp.py passes for DW=8 but fails for DW=32
* removed the state machine and replaced it by a sequential
code
* this fixes the mac_core testbench
* only for 8 bit datapath for now
* but probes and reads not
* in some cases, the delayed sink data was updated even though
sink was not valid, leading to corrupted source data
* this broke etherbone reads with DW=64
* push IP address directly into ARP table * re-organize unit-test structure * remove some debug prints
* because some phy's don't have buffers and don't like to be stalled * add stall checks to test_icmp.py
* 64 bit datapath needs to stall the PHY by design * need some buffer somewhere to avoid that with real hardware
* to prevent stalling the PHY when using etherbone with DW=64
* due to StrideConverter bug
This reverts commit 09d59c0. To my surprise, stalling the XGMII PHY seems to work fine on hardware. The anti-underflow FIFO does not seem to be required. I haven't yet investigated why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tweaks to improve icmp and etherbone testing and troubleshooting.
quenchfield intoidentandsequencefieldssend()calculate the checksum of the icmp-packetThis needs some changes to litex, in particular to
PacketLogger,PacketStreamerandStrideConverter, which is why CI is failing. See the corresponding pull request to litex