feat: add 5ireChain #602
feat: add 5ireChain #602
Conversation
WalkthroughThis pull request introduces support for the 5ireChain blockchain network to the Enkrypt wallet. The changes include updating the README.md to list 5ireChain as a supported network, creating a new network configuration file for 5ire in the Ethereum providers, and extending the network types to include the new network in the NetworkNames and CoingeckoPlatform enums. Changes
Sequence DiagramsequenceDiagram
participant User
participant Enkrypt Wallet
participant 5ireChain Network
User->>Enkrypt Wallet: Select 5ireChain Network
Enkrypt Wallet->>5ire.ts: Load Network Configuration
5ire.ts-->>Enkrypt Wallet: Return Network Details
Enkrypt Wallet->>5ireChain Network: Connect and Interact
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/extension/src/providers/ethereum/networks/5ire.ts (1)
18-18: Consider adding multiple RPC endpoints for redundancy.The network configuration currently uses a single RPC endpoint. Consider adding fallback RPC nodes to improve reliability.
- node: 'https://rpc.5ire.network', + node: [ + 'https://rpc.5ire.network', + // Add additional official RPC endpoints here + ],
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
packages/extension/src/providers/ethereum/networks/icons/5ire.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
README.md(1 hunks)packages/extension/src/providers/ethereum/networks/5ire.ts(1 hunks)packages/types/src/networks.ts(2 hunks)
🔇 Additional comments (5)
packages/extension/src/providers/ethereum/networks/5ire.ts (2)
12-13: Ensure block explorer URL templates are correct.The block explorer URL templates use
[[txHash]]and[[address]]placeholders. Verify these are the correct formats for 5irescan.io.✅ Verification successful
Block explorer URL templates are correctly implemented.
The URL templates follow the standard format used by EVM block explorers, consistent with other networks in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other block explorer URL formats in the codebase rg "blockExplorerTX.*:" -A 1 rg "blockExplorerAddr.*:" -A 1Length of output: 46542
14-14: Verify the chain ID matches the official 5ireChain documentation.The chain ID is set to
0x3e3(995 in decimal). Please ensure this matches the official 5ireChain documentation.packages/types/src/networks.ts (1)
99-99: LGTM! Consistent enum values.The network name and platform identifiers are consistently defined as "5ire" across both enums.
Also applies to: 158-158
README.md (2)
111-111: LGTM! Documentation updated correctly.5ireChain has been added to the list of supported chains in alphabetical order.
Line range hint
22-23: Verify integration with activity and asset handlers.Please ensure that:
- The Etherscan-style activity handler is compatible with 5irescan.io's API
- The MEW asset info handler supports 5ireChain tokens
✅ Verification successful
Both handlers are properly integrated and compatible with 5ireChain
The implementation follows the standard pattern used across other EVM networks:
- MEW asset info handler is correctly integrated for EVM token support
- EtherscanActivity handler is properly configured for 5irescan.io which follows the Etherscan API standard
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for similar configurations in other networks rg "assetsInfoHandler.*mew" -B 5 -A 5 rg "activityHandler.*EtherscanActivity" -B 5 -A 5Length of output: 69060
🧰 Tools
🪛 LanguageTool
[duplication] ~109-~109: Possible typo: you repeated a word.
Context: ...Network - Viction - Westend - ZChains - zkSync - zkSync Goerli - 5ireChain - More coming soon! ...(ENGLISH_WORD_REPEAT_RULE)
Summary by CodeRabbit
New Features
Documentation