Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to the Publishing Report widget #1125 #1126

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Conversation

ashklianko
Copy link
Member

No description provided.

@ashklianko ashklianko linked an issue Nov 13, 2023 that may be closed by this pull request
Copy link
Member

@alansemenov alansemenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "Unpublish" icon is missing here:
image
  1. "Publish" icon is missing here:
image

@alansemenov
Copy link
Member

Another bug (should've been in another issue, but might as well fix it here).

Here's a version history of an item which was published 18.10, then unpublished 02.11, then published again 13.11:
image

A report from 01.11 until 13.11 looks like this:

image

The item was already online on the "from" date, so we should find a published version before this date (which happened 18.10) and compare it with publishing from 13.11 + show a subtitle that the item was offline from 02.11.

With the latest change (where we look for a published version before the From date) we should never start the report with "Item went offline", as far as I understand.

@ashklianko
Copy link
Member Author

Updateed

@alansemenov alansemenov self-requested a review November 16, 2023 10:11
@alansemenov alansemenov merged commit bce1c7c into master Nov 16, 2023
4 checks passed
@alansemenov alansemenov deleted the issue-1125 branch November 16, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icons to the Publishing Report widget
2 participants