-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility A #3688
Merged
Merged
Accessibility A #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alansemenov
force-pushed
the
epic-accessibility
branch
from
September 9, 2024 08:04
b188657
to
c8af314
Compare
New SNAPSHOT version
alansemenov
force-pushed
the
epic-accessibility
branch
from
September 11, 2024 08:02
c8af314
to
c70e426
Compare
This reverts commit 863edd8.
alansemenov
changed the base branch from
master
to
epic-accessibility-squashed
September 11, 2024 08:54
edloidas
added a commit
that referenced
this pull request
Sep 12, 2024
alansemenov
added a commit
that referenced
this pull request
Sep 12, 2024
* Accessibility A (#3688) * Enable setting `lang` and `role` attributes #3615 #3619 * Refactor AppIcon & TabbedAppBar #3625 * Accessibility: Toolbar #3626 * Implement an interface with WCAG properties #3641 * Accessibility: Toolbar #3626 * Accessibility: AppBar #3638 * Support aria-haspopup attribute on Element #3650 * Accessibility: Toolbar navigation #3642 * Fixed misc issues * Fixed Checkbox not getting checked * Fixed focus on modal dialog buttons * Accessibility: Toolbar navigation #3642 * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Accessibility: Input highlighting #3687 * Use display: flex for TabMenu * Don't try to reapply focus to the last focused element if there was none * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Made buttons trigger action on Space * Changes to comply with ESLint 9 #3693 * Revert "Publish SNAPSHOT from the epic branch" This reverts commit 863edd8. * Accessibility A (#3688) --------- Co-authored-by: Mikita Taukachou <[email protected]>
alansemenov
added a commit
that referenced
this pull request
Sep 13, 2024
* Enable setting `lang` and `role` attributes #3615 #3619 * Refactor AppIcon & TabbedAppBar #3625 * Accessibility: Toolbar #3626 * Implement an interface with WCAG properties #3641 * Accessibility: Toolbar #3626 * Accessibility: AppBar #3638 * Support aria-haspopup attribute on Element #3650 * Accessibility: Toolbar navigation #3642 * Fixed misc issues * Fixed Checkbox not getting checked * Fixed focus on modal dialog buttons * Accessibility: Toolbar navigation #3642 * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Accessibility: Input highlighting #3687 * Use display: flex for TabMenu * Don't try to reapply focus to the last focused element if there was none * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Made buttons trigger action on Space * Changes to comply with ESLint 9 #3693 * Revert "Publish SNAPSHOT from the epic branch" This reverts commit 863edd8. * Accessibility A (#3688) --------- Co-authored-by: Mikita Taukachou <[email protected]>
alansemenov
added a commit
that referenced
this pull request
Sep 15, 2024
* Enable setting `lang` and `role` attributes #3615 #3619 * Refactor AppIcon & TabbedAppBar #3625 * Accessibility: Toolbar #3626 * Implement an interface with WCAG properties #3641 * Accessibility: Toolbar #3626 * Accessibility: AppBar #3638 * Support aria-haspopup attribute on Element #3650 * Accessibility: Toolbar navigation #3642 * Fixed misc issues * Fixed Checkbox not getting checked * Fixed focus on modal dialog buttons * Accessibility: Toolbar navigation #3642 * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Accessibility: Input highlighting #3687 * Use display: flex for TabMenu * Don't try to reapply focus to the last focused element if there was none * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Made buttons trigger action on Space * Changes to comply with ESLint 9 #3693 * Revert "Publish SNAPSHOT from the epic branch" This reverts commit 863edd8. * Accessibility A (#3688) --------- Co-authored-by: Mikita Taukachou <[email protected]>
alansemenov
added a commit
that referenced
this pull request
Sep 15, 2024
* Enable setting `lang` and `role` attributes #3615 #3619 * Refactor AppIcon & TabbedAppBar #3625 * Accessibility: Toolbar #3626 * Implement an interface with WCAG properties #3641 * Accessibility: Toolbar #3626 * Accessibility: AppBar #3638 * Support aria-haspopup attribute on Element #3650 * Accessibility: Toolbar navigation #3642 * Fixed misc issues * Fixed Checkbox not getting checked * Fixed focus on modal dialog buttons * Accessibility: Toolbar navigation #3642 * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Accessibility: Input highlighting #3687 * Use display: flex for TabMenu * Don't try to reapply focus to the last focused element if there was none * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Made buttons trigger action on Space * Changes to comply with ESLint 9 #3693 * Revert "Publish SNAPSHOT from the epic branch" This reverts commit 863edd8. * Accessibility A (#3688) --------- Co-authored-by: Mikita Taukachou <[email protected]>
alansemenov
added a commit
that referenced
this pull request
Sep 17, 2024
* Enable setting `lang` and `role` attributes #3615 #3619 * Refactor AppIcon & TabbedAppBar #3625 * Accessibility: Toolbar #3626 * Implement an interface with WCAG properties #3641 * Accessibility: Toolbar #3626 * Accessibility: AppBar #3638 * Support aria-haspopup attribute on Element #3650 * Accessibility: Toolbar navigation #3642 * Fixed misc issues * Fixed Checkbox not getting checked * Fixed focus on modal dialog buttons * Accessibility: Toolbar navigation #3642 * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Accessibility: Input highlighting #3687 * Use display: flex for TabMenu * Don't try to reapply focus to the last focused element if there was none * Refactor ActionButton and MenuButton #3677 * Refactor ActionButton and MenuButton #3677 * Made buttons trigger action on Space * Changes to comply with ESLint 9 #3693 * Revert "Publish SNAPSHOT from the epic branch" This reverts commit 863edd8. * Accessibility A (#3688) --------- Co-authored-by: Mikita Taukachou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.