Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site baseUrl #10349

Closed
rymsha opened this issue Dec 1, 2023 · 3 comments
Closed

Site baseUrl #10349

rymsha opened this issue Dec 1, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@rymsha
Copy link
Contributor

rymsha commented Dec 1, 2023

Site baseUrl stored in siteConfig under "system" application key: com.enonic.xp.site

"data": {
    "siteConfig": [
      {
        "applicationKey": "com.enonic.xp.site",
        "config": { "baseUrl": "https://www.example.com:8443/path" }
        ...

Can be used for various purposes, similar to how html <base> element used for, but on backend. (although domain part is always required)

  • generation of sitemap.xml links
  • links in emails
  • links in rss
  • pageUrl generation when not is scope of request (?)

Examples of baseUrl:

https://www.example.com:8443/path

www.example.com (equivalent to //www.example.com)

www.exaple.com/my-site (equivalent to //www.example.com/my-site)

http://www.example.com

http://www.example.com:8080

https://www.example.com:8443

https://enonic.atlassian.net/wiki/spaces/TD/pages/2743304247/Site+base+URL

@rymsha rymsha added the Feature label Dec 1, 2023
@rymsha rymsha added this to the 8.0.0 milestone Dec 1, 2023
@rymsha
Copy link
Contributor Author

rymsha commented Dec 1, 2023

When implemented, CS should be adjusted to ignore com.enonic.xp.site applicationKey

@rymsha rymsha moved this from Backlog to Current Sprint in XP8 - Universal API Dec 15, 2023
@anatol-sialitski anatol-sialitski moved this from Current Sprint to In Progress in XP8 - Universal API Jul 3, 2024
anatol-sialitski added a commit that referenced this issue Jul 4, 2024
anatol-sialitski added a commit that referenced this issue Jul 4, 2024
anatol-sialitski added a commit that referenced this issue Jul 8, 2024
@anatol-sialitski anatol-sialitski moved this from In Progress to Current Sprint in XP8 - Universal API Jul 10, 2024
@alansemenov alansemenov moved this from Current Sprint to In Progress in XP8 - Universal API Jul 11, 2024
@alansemenov alansemenov moved this from In Progress to Backlog in XP8 - Universal API Jul 11, 2024
@sigdestad
Copy link
Member

Just saving some alternative "application key" names

"cms"
"portal"
"site"

@sigdestad
Copy link
Member

For inspiration - this is what the Content Studio UI might look like:

Image

General idea - we filter out selected/system applications and list them in a separate step, and we prevent deleting it. This will align site closer with "project" form as well.

@alansemenov alansemenov moved this from Current Sprint to In Progress in XP8 - Universal API Feb 3, 2025
anatol-sialitski added a commit that referenced this issue Feb 13, 2025
anatol-sialitski added a commit that referenced this issue Feb 13, 2025
@anatol-sialitski anatol-sialitski moved this from In Progress to Done in XP8 - Universal API Feb 13, 2025
anatol-sialitski added a commit that referenced this issue Feb 17, 2025
anatol-sialitski added a commit that referenced this issue Feb 18, 2025
anatol-sialitski added a commit that referenced this issue Feb 27, 2025
anatol-sialitski added a commit that referenced this issue Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants