Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media image API handler #10882 #10924

Merged
merged 9 commits into from
Feb 27, 2025

Media image API handler #10882

cd4bd0b
Select commit
Loading
Failed to load commit list.
Merged

Media image API handler #10882 #10924

Media image API handler #10882
cd4bd0b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 27, 2025 in 1s

84.77% (+0.14%) compared to 20e113c

View this Pull Request on Codecov

84.77% (+0.14%) compared to 20e113c

Details

Codecov Report

Attention: Patch coverage is 89.34010% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (20e113c) to head (cd4bd0b).
Report is 12 commits behind head on media-epic.

Files with missing lines Patch % Lines
.../portal/impl/handler/image/ImageHandlerWorker.java 30.76% 5 Missing and 4 partials ⚠️
...a/com/enonic/xp/portal/impl/MediaHashResolver.java 83.33% 2 Missing and 3 partials ⚠️
...nonic/xp/portal/impl/handler/MediaHandlerBase.java 91.66% 1 Missing and 3 partials ⚠️
.../impl/handler/AbstractAttachmentHandlerWorker.java 77.77% 0 Missing and 2 partials ⚠️
.../java/com/enonic/xp/portal/url/ImageUrlParams.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             media-epic   #10924      +/-   ##
================================================
+ Coverage         84.62%   84.77%   +0.14%     
- Complexity        19993    20138     +145     
================================================
  Files              2628     2640      +12     
  Lines             69475    70048     +573     
  Branches           5605     5606       +1     
================================================
+ Hits              58791    59380     +589     
+ Misses             7979     7954      -25     
- Partials           2705     2714       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov