Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson Json dependency must not be in api #10384 #10935

Merged
merged 7 commits into from
Feb 27, 2025

tests

1cd7bd6
Select commit
Loading
Failed to load commit list.
Merged

Jackson Json dependency must not be in api #10384 #10935

tests
1cd7bd6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 27, 2025 in 0s

84.67% (+0.02%) compared to c029739

View this Pull Request on Codecov

84.67% (+0.02%) compared to c029739

Details

Codecov Report

Attention: Patch coverage is 86.25430% with 40 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (c029739) to head (1cd7bd6).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/enonic/xp/core/internal/json/JsonHelper.java 69.56% 5 Missing and 2 partials ⚠️
...in/java/com/enonic/xp/repository/IndexMapping.java 45.45% 6 Missing ⚠️
...n/java/com/enonic/xp/repository/IndexSettings.java 45.45% 6 Missing ⚠️
...i/src/main/java/com/enonic/xp/util/JsonHelper.java 0.00% 5 Missing ⚠️
...enonic/xp/repo/impl/index/IndexSettingsMerger.java 60.00% 3 Missing and 1 partial ⚠️
...epo/impl/repository/NodeRepositoryServiceImpl.java 89.47% 2 Missing ⚠️
...repo/impl/repository/RepositoryNodeTranslator.java 50.00% 2 Missing ⚠️
...om/enonic/xp/lib/repo/CreateRepositoryHandler.java 0.00% 2 Missing ⚠️
...om/enonic/xp/lib/repo/mapper/RepositoryMapper.java 50.00% 2 Missing ⚠️
.../java/com/enonic/xp/testing/helper/JsonAssert.java 83.33% 2 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #10935      +/-   ##
============================================
+ Coverage     84.65%   84.67%   +0.02%     
+ Complexity    19949    19940       -9     
============================================
  Files          2620     2620              
  Lines         69329    69261      -68     
  Branches       5596     5567      -29     
============================================
- Hits          58690    58648      -42     
+ Misses         7932     7919      -13     
+ Partials       2707     2694      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov