Websocket control protocol (PR to run integration tests on github proper) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoperm
force-pushed
the
websocket-control-protocol
branch
2 times, most recently
from
0c44b45 to
0fc0c40
Compare
The necessary behaviour is already in place, but the wasm build only issued GETs, and the handler was not invoked.
Still needs some way to assert that clients are connected through websockets, rather than the TCP hijacking version of DERP.
enoperm
force-pushed
the
websocket-control-protocol
branch
from
1c66e51 to
ce402c4
Compare
enoperm
force-pushed
the
websocket-control-protocol
branch
from
04aefaa to
73e3383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.