Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DNSSEC to DNSSECImpl and DNSSECInterface to DNNSSEC #36

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Rename DNSSEC to DNSSECImpl and DNSSECInterface to DNNSSEC #36

merged 1 commit into from
Aug 29, 2018

Conversation

Arachnid
Copy link
Member

No description provided.

@Arachnid Arachnid requested a review from decanus August 29, 2018 10:14
decanus
decanus approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@decanus decanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly hate *Impl naming, but I guess there is no way around this. Unless we maybe call it DNSSECOracle or some thing like that.

@Arachnid
Copy link
Member Author

I honestly hate *Impl naming, but I guess there is no way around this. Unless we maybe call it DNSSECOracle or some thing like that.

I agree. But if we call it that, the interface should probably be called that too.

I prefer calling the interface by the bare name than '*Interface', because it's the one people will deal with day-to-day.

@Arachnid Arachnid merged commit 08c647e into master Aug 29, 2018
@Arachnid Arachnid deleted the renname branch August 29, 2018 10:21
@decanus
Copy link
Contributor

decanus commented Aug 29, 2018

I agree there, with the Interface part. But the *Impl part just annoys me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decanus decanus decanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arachnid @decanus