Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean out node modules #94

Closed
meldckn opened this issue Nov 27, 2019 · 1 comment
Closed

Clean out node modules #94

meldckn opened this issue Nov 27, 2019 · 1 comment
Labels
build process cleanup

Comments

@meldckn
Copy link
Collaborator

meldckn commented Nov 27, 2019 •
edited
Loading

Clean out unused npm modules. Surely we don't need all 340 installed in node_modules (and that's just the top level!).

I'm not sure how to tell if a particular module is actually used though..
mkremins added a commit that referenced this issue Nov 28, 2019
@mkremins
Clean up Gruntfile and node_modules a bit
a4fbbdd 
Partially addresses #94 and #98.
@mkremins
Copy link
Collaborator

mkremins commented Dec 1, 2019

Cleaned out the node_modules dependencies in the process of upgrading from NW.js to Electron for release v1.1.0. In the future, we'll have to clean out the dependencies whenever we change them; the easiest way to do this seems to be to remove the node_modules folder and the package-lock.json file at the repository root, then re-run npm install in the terminal.

@mkremins mkremins closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build process cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkremins @meldckn