Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5042 implement uninstall in mocked state #1523

Merged
merged 8 commits into from
Sep 12, 2023

Conversation

ichalagashvili
Copy link
Member

@ichalagashvili ichalagashvili commented Jul 20, 2023

Implements uninstall modal for different scenarios and cases (scenarios can be checked in the ticket)

@github-actions
Copy link

Requested publication of version 7.3.0-ENG-5042-PR-1523

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the "coverage" issues

@ichalagashvili ichalagashvili marked this pull request as ready for review July 28, 2023 00:32
@github-actions
Copy link

Requested publication of version 7.3.0-ENG-5042-PR-1523

@github-actions
Copy link

Requested publication of version 7.3.0-ENG-5042-PR-1523

@github-actions
Copy link

Requested publication of version 7.3.0-ENG-5042-PR-1523

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Requested publication of version 7.3.0-ENG-5042-PR-1523

DMinnai
DMinnai previously approved these changes Sep 12, 2023
Copy link
Contributor

@ryanjpburgos ryanjpburgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just don't know if wanna keep all the console.logs

@github-actions
Copy link

Requested publication of version 7.3.0-ENG-5042-PR-1523

@github-actions
Copy link

Requested publication of version 7.3.0-ENG-5042-PR-1523

@ichalagashvili ichalagashvili dismissed github-actions[bot]’s stale review September 12, 2023 12:50

its already fixed but github wont rerun it

@ichalagashvili ichalagashvili merged commit bde3fed into develop Sep 12, 2023
@ichalagashvili ichalagashvili deleted the ENG-5042_implement_uninstall branch September 12, 2023 12:50
@github-actions
Copy link

Requested publication of version 7.3.0-ENG-5042-PR-1523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants