Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-496 update databases.md & ecr-overview.md #509

Merged
merged 2 commits into from
May 18, 2022
Merged

ENDOC-496 update databases.md & ecr-overview.md #509

merged 2 commits into from
May 18, 2022

Conversation

jyunmitch
Copy link
Collaborator

Editing for grammar, standards, and better structure. Attempting to break-up big paragraphs with minor headers, shorter sentences and lists where possible.

@jyunmitch jyunmitch requested review from nshaw and Lyd1aCla1r3 May 9, 2022 20:51
Copy link
Contributor

@nshaw nshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a quick read.

@@ -2,76 +2,68 @@

## Introduction

The Entando Component Repository (ECR) is meant to be a repository to
share reusable components among different Entando instances.
The Entando Component Repository (ECR) is a central repository where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

central to what? not sure this is accurate or necessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about the Hub

The Entando Component Repository (ECR) is meant to be a repository to
share reusable components among different Entando instances.
The Entando Component Repository (ECR) is a central repository where
reusable components can be shared across enterprises and applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"applications and enterprises" -- "applications" should come before "enterprises" to progressively expand scope

The following glossary relates to the ECR and related concepts:

## Glossary
The following examines some of the nuts and bolts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following what? should have subject explicit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything that follows. It doesn't need explicit subject.


### Component

An Entando component - simply referred to as component - is a piece of
An Entando Component - simply referred to as component - is a piece of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't think we were capitalizing "component" anywhere ?? i haven't seen that; is this a new rule?

application. Examples of components are widgets, microfrontends,
content-types, labels, plugins, and static resources
application. Examples of components are widgets, micro frontends,
content-types, labels, plugins, and static resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content types - not hyphenated, and actually capitalized on other pages but could see it lowercase here

For `spec.dbms` property you should choose `none`, then you should add all needed DB connection parameters.
After updating parameters with the one you need, you should end with a yaml like this:
For `spec.dbms` property, choose `none`. Then add the necessary DB connection parameters.
Here is an example of the resulting entandoapp.yaml:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml file backticked

Then adding those variables under the `spec.environmentVariables` section will supply connection parameters that will be used by EntandoApp.
Keep in mind that all these parameters will be applied to each of the containers in the EntandoApp pod and that they will also override existing values.
* Using `spec.dbms: "none"` directs the operator to skip the initial schema/user creation step.
* Adding the variables under the `spec.environmentVariables` section will supply connection parameters that will be used by EntandoApp.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Adding variables" or specify which variables

are two EntandoDatabaseServices that have the same DBMS vendor, it will
### How It Works
#### Database Custom Resource
In order for the EntandoApp and Plugin deployer to choose the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a single deployer? why is deployer not capitalized? i feel like this should read "EntandoApp and plugin deployer"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a s single deployer job per plugin which does its work and then shuts down.

database of another user.
>MySQL limits database names
to 63 characters. Keep this in mind when naming your
Entando Applications and Plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugins

@nshaw nshaw merged commit 6774a51 into main May 18, 2022
@nshaw nshaw deleted the ENDOC-496 branch May 18, 2022 16:39
@jyunmitch jyunmitch restored the ENDOC-496 branch May 20, 2022 13:45
@jyunmitch jyunmitch deleted the ENDOC-496 branch May 20, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants