Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-520 Entando cluster must be able to access git repo to install bundle #535

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

Lyd1aCla1r3
Copy link
Contributor

No description provided.

@Lyd1aCla1r3 Lyd1aCla1r3 requested review from nshaw and jyunmitch July 13, 2022 05:01
- A working DNS server configured to resolve internal and external names. To configure K8s with a global wildcard domain name for the entire cluster, be sure it points to the public IP address of the external load balancer for the worker nodes.
- A default [storage class](https://kubernetes.io/docs/concepts/storage/storage-classes/) is needed for the Entando Operator to create the correct persistent volume claims (PVC) for each pod.
- NGINX [ingress controller](https://kubernetes.github.io/ingress-nginx/deploy/) is needed to expose the Entando Application.
- To publish bundles that do not contain Docker images to Git, the cluster containing the Entando Application must have access to the bundle repository, which can be public or private.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this out as 2 items:

  • To install bundles, the cluster containing the Entando Application must have access to the bundle repository (either public or private, often on GitHub) as well as the Docker image repository (e.g. DockerHub) for any microservices.

FYI, for 7.1, the new bundle style will be to draw only from Docker, but I believe the current style will still be supported so this requirement won't immediately change

- 6 GB of RAM
- 5 GB of allocated storage distributed in many PVCs
- 5 GB of allocated storage distributed over many PVC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does PVC not require 's' for plural

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match all the other instances of acronyms representing plural expansions that are not given an s. there were several on this page. the inconsistencies were noticeable, and changing all plural acronyms to have an s was overkill

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's worth fixing but PVC is definitely singular so many PVC feels wrong. You have a Persistent Volume Claim (PVC) or many Persistent Volume Claims (many PVCs)...


Note: Some DevOps teams warn against running databases inside pods in production environments.
> Note: The decision to run databases inside production environment pods is controversial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change the meaning at all? are pods inside the production environment the same as production environment pods?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the meaning is the same and it reads better; too many articles and verbs up against each other in the former, and no reason given for why devops issue warning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's quite the same. It's not a controversial topic per se, some DevOps teams prefer one versus the other. Controversy somehow applies moral ambiguity to me and that isn't the case here. Maybe "Note: Some DevOps teams recommend against running production databases inside pods since it makes database management more challenging."

@Lyd1aCla1r3 Lyd1aCla1r3 merged commit f93d3cb into main Jul 14, 2022
@nshaw nshaw deleted the ENDOC-520 branch August 26, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants