Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-522 ent-cli reorg basics and nav #536

Merged
merged 34 commits into from
Aug 4, 2022
Merged

ENDOC-522 ent-cli reorg basics and nav #536

merged 34 commits into from
Aug 4, 2022

Conversation

jyunmitch
Copy link
Collaborator

@jyunmitch jyunmitch commented Jul 19, 2022

No description provided.

@jyunmitch jyunmitch requested a review from Lyd1aCla1r3 July 19, 2022 19:05
@jyunmitch jyunmitch requested a review from nshaw July 22, 2022 20:26
@@ -51,18 +50,17 @@ ent [command] [subcommand] [name] [flags]
> ent Commands:
- app => Helper for managing an Entando App
- app-info => Displays information about an Entando App
- bundle => Helper for managing bundle functions. See below for more details
- bundle => Helper module for managing bundle functions. (See below for more details)
- bundler => export of resources from a running instance for v1 bundles only
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshaw only mentioned version here for bundler. Thinking I'll get into the details of the v1/v5 issues in the project management page. Thought I'd keep it more generic here. Any thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyunmitch Maybe even there we can use the phrase "git-based bundles (v1)". I think git-based versus docker-based is going to be the most easily understood.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe - "export resources from a running instance as a git-based (v1) bundle." Then the previous line can be "Helper module for managing docker-based (v5) bundles. (See below for more details)"

Copy link
Contributor

@nshaw nshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated diag section looks good.

@@ -51,18 +50,17 @@ ent [command] [subcommand] [name] [flags]
> ent Commands:
- app => Helper for managing an Entando App
- app-info => Displays information about an Entando App
- bundle => Helper for managing bundle functions. See below for more details
- bundle => Helper module for managing bundle functions. (See below for more details)
- bundler => export of resources from a running instance for v1 bundles only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe - "export resources from a running instance as a git-based (v1) bundle." Then the previous line can be "Helper module for managing docker-based (v5) bundles. (See below for more details)"

> Collected diagdata available in archive "~/.entando/reports/entando-diagdata-2020-11-19T02:58:47+0000.tgz"
```

::: tip
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't understand why this tip is here suddenly, it seems to need some context

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no other context. this was its own section previously. it's not a description of how things should function or a tutorial for what to do in an expected use case. moving it to tips and tricks is an option but doesn't seem merited. either a tip or a note seems more appropriate.

| `ent diag` | Run diagnostics on the pods currently in an Entando namespace and prepare a diagnostic tar.gz
| `ent pod grep --all "error\|fail"` | Locate error messages within EntandoApp pods

The command `ent diag` is a superset of operations to analyze, organize and output detailed pod information. In addition to calling `ent pod-info`, `ent diag` exports custom resources, ingresses, deployments, "previous" pod logs, namespace events, etc. It also generates diagnostics and returns log paths similar to the following:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the word superset>> it should be a set that is bigger than something else and I don't know that that's the case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a superset

Copy link
Contributor

@nshaw nshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things jumped out at me.

path: path + 'getting-started/entando-cli.md',
},
{
title: 'ent Bundle Management',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think lowercase ent looks okay in the left nav when everything else is capitalized? I thought we discussed dropping ent it in the nav and just having Bundle Management, API Management, etc. since the context should be obvious.


# Diagnostics and Troubleshooting

Diagnostic information is critical to analysis and troubleshooting, and the Entando CLI (ent) is a useful tool for debugging issues with an Entando instance. The [Getting Started](../../docs/getting-started/README.md) guide includes steps to install ent in a Multipass VM. The following commands can be run from this VM for insight into an Entando Application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the 2nd and 3rd sentences. These commands are useful against any Entando instance, not just a Multipass VM.

@jyunmitch jyunmitch merged commit 27abe16 into main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants