-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENDOC-535-ssl-note #546
Merged
Merged
ENDOC-535-ssl-note #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyd1aCla1r3
reviewed
Aug 3, 2022
@@ -140,6 +140,14 @@ Now let's create a new application similar to Scenario 3, but with the self-sign | |||
|
|||
Once the deployment is complete, you can confirm that all routes use HTTPS with the self-signed certificate. You may still see security warnings in the browser. | |||
|
|||
#### Note: Multiple Certificate Chains | |||
If you have multiple certificates to load into Openshift, you must pass each certificate with its own identifier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenShift
#### Note: Multiple Certificate Chains | ||
If you have multiple certificates to load into Openshift, you must pass each certificate with its own identifier. | ||
```bash | ||
ca0.crt: -\> a single ca certificate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CA
nshaw
suggested changes
Aug 3, 2022
@@ -140,6 +140,14 @@ Now let's create a new application similar to Scenario 3, but with the self-sign | |||
|
|||
Once the deployment is complete, you can confirm that all routes use HTTPS with the self-signed certificate. You may still see security warnings in the browser. | |||
|
|||
#### Note: Multiple Certificate Chains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A certificate chain by definition involves multiple certificates so we can simplify the title to Certificate Chain.
- Maybe we should either move this note up to step 4, or connect to it here as a foot note. Otherwise they may do the whole thing and then only see this note at the bottom after it fails.
nshaw
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.