ENDOC-561 edits to simple MFE tutorial #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshaw
approved these changes
Sep 6, 2022
| @@ -90,6 +92,7 @@ You’re now using a custom element to display a React app. | |||
|
|
|||
| 1. From the root bundle directory, generate the Docker image: | |||
| ``` sh | |||
| cd simple-bundle | |||
There was a problem hiding this comment.
I don't think you need this command. If you're in the MFE subdirectory, you would either use cd ../.. - or simply leave the comment that they should work from the root bundle directory.
nshaw
approved these changes
Sep 6, 2022
jyunmitch
reviewed
Sep 7, 2022
| @@ -13,23 +13,25 @@ | |||
| ent bundle init simple-bundle | |||
| ``` | |||
|
|
|||
| 2. Add an MFE to the bundle project structure: | |||
| 2. From the root bundle folder, add an MFE to the bundle project structure: | |||
There was a problem hiding this comment.
adding an MFE is not really adding it to the structure, so this seems misleading, like it's only a structural thing when it adds a folder but also adds it to the entando.json
There was a problem hiding this comment.
disagree, because structure pertains to both file contents and directory, like how code is written as well as file hierarchy. i'll remove "structure" to keep both implied without an extra word
| npx create-react-app simple-mfe --use-npm | ||
| ``` | ||
| Use the bundle name you chose when adding an MFE to overwrite the empty bundle folder created in the previous step. | ||
| Assign the same bundle name you chose when adding an MFE to overwrite that empty bundle folder. |
There was a problem hiding this comment.
empty bundle folder>> empty MFE folder
Lyd1aCla1r3
changed the title
Lyd1aCla1r3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.