Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENDOC-539 Apply feedback re bundle cli #571
ENDOC-539 Apply feedback re bundle cli #571
Changes from 2 commits
35f4de3
2a2ef0d
1b9e258
d2a451c
c782c76
53143bf
e8632b2
230bda6
d2f570e
a9842f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still don't think export is accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess leave a comment on notion. to export a CR is common terminology and logical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think export actually works here. What's happening here is creating the descriptor file for a custom resource - generated is the standard language in all the tools, hence ent prj generate-cr. Export implies taking something out of one system so it can be used in another but the custom resource is actually being written (generated) from the data in the repository. Arguably if the CR existed as a thing in the repository, then it might be an export but that isn't the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for clarifying; i had thought that the CR was generated in the cluster before the bundle was pulled into the ECR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing, we probably shouldn't use an example of 7.2.0 which doesn't exist yet. Either we should use the current release, or make it generic. Probably v7.1.0 is best.